Skip to content

More data for func execution metrics

Ecarg requested to merge grace/T375457/optimize-or-add-better-data-to-func-metrics into main

Initially created to add more info to metrics but I'm beginning to realize this may be a kind of anti-practice, a misuse of Prom Metrics, and really should be done via logging. Adding more unique and dynamic data to the metrics info will increase cardinality, storage costs, and slow down querying. However, we should keep reqId and function info for now and add metrics and logging whenever an implementation fails.

  • adds new metric that will get created upon implementation error and logs the reqId
  • adds boolean to metric label indicating whether or not Z7 was a built-in or evaluated
  • refactoring and also of helper method (which can be moved to function-schemata?)

The hope is to query this data by grouping by reqId's (or function type as needed) on Grafana

Bug: T375457

Edited by Ecarg

Merge request reports